exelix11 / SysDVR

Stream switch games to your PC via USB or network
GNU General Public License v2.0
1.52k stars 89 forks source link

Atmosphere crash when opening internet settings #295

Open Carlcooper opened 5 months ago

Carlcooper commented 5 months ago

Describe the bug When opening internet settings, the atmosphere cfw would crash.

To Reproduce Open the internet settings with SYS Dvr

Expected behavior Expected the internet settings applet to open.

Setup information

Additional context I found out the bug through renaming the sys module ID in the content folder.

exelix11 commented 5 months ago

Are you sure it's not a combination of other mods ? Try in a clean install of ams

ArcDelta commented 5 months ago

Atmosphere crashes under those cirumctances (in my own case) when having a theme installed. I don't know why it does happen under those circumstances or if there are more ways to trigger this crash on Atmosphere.

ArcDelta commented 5 months ago

I decided to delete the /atmosphere/contents/00FF0000A53BB665 folder (in other words, getting rid of SysDVR) and everything works fine with the themes, which means that the problem is a compatibility between the themes AND SysDVR (at least in my particular case).

exelix11 commented 5 months ago

I don't think anyone else has reported this same issue as you. Sysdvr is known to cause memory issues if you have other sysmodules. Of course themes have the same problem since they slightly increase memory usage. So I'd suggest trying a clean install of atmosphere and enabling things one at a time.

DefenderOfHyrule commented 5 months ago

Describe the bug When opening internet settings, the atmosphere cfw would crash.

To Reproduce Open the internet settings with SYS Dvr

Expected behavior Expected the internet settings applet to open.

Setup information

* Console firmware (17.0.0)

* Atmosphere 1.6.2

* SysDVR version (v1.0.11)

Additional context I found out the bug through renaming the sys module ID in the content folder.

Describe the bug When opening internet settings, the atmosphere cfw would crash.

To Reproduce Open the internet settings with SYS Dvr

Expected behavior Expected the internet settings applet to open.

Setup information

* Console firmware (17.0.0)

* Atmosphere 1.6.2

* SysDVR version (v1.0.11)

Additional context I found out the bug through renaming the sys module ID in the content folder.

This issue can have several causes, the main one being SysDVR in combination with ldn_mitm, (assuming this is error code 2162-0002 with program ID 0100000000001006). I haven't extensively looked into it yet but it has been happening since atmosphere 1.6.0+ iirc (as I am the "main" maintainer of ldn_mitm now I guess (?))

exelix11 commented 5 months ago

Is there a way to profile HOS memory pools to know if the cause really is too many sysmodules ? For sysdvr i really tried to reduce memory usage to the minimum possible, i link without malloc and the bottleneck are the socket and video capture buffers so i don't think this can ever be fixed.

DefenderOfHyrule commented 5 months ago

I don't personally know if there is a way to profile that but I doubt it's a RAM issue as it did work before atmosphere 1.6.0 as far as I can remember, it's likely not an issue with sysdvr/ldn_mitm either as they work independently but not when used together (maybe something regarding the priority of sysmodules? not sure if relevant at all, just mentioning it)

exelix11 commented 5 months ago

I don't track ams versions vs crash reports so really can't say. Did you try asking on reswitched ? Maybe someone there can at least point us to the right direction.

DefenderOfHyrule commented 5 months ago

I haven't tried asking in RS, I might do so later (unless you want to do so first) but it's a strange issue. I appreciate your replies

exelix11 commented 5 months ago

I didn't cause tbh i thought it was user error of having a messed up ams setup, i only received a couple of these crash reports. Go ahead and ask, make sure to ping me so i can follow the convo.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open for 30 days with no activity.

Rafacasari commented 3 months ago

Happening to me aswell on firmware 18.1.0 with latest build

longruhai0901 commented 3 months ago

on firmware 16.1.0,crashed; when I remove the SysDVR 6.1.1, then the internet setting ok

longruhai0901 commented 3 months ago

When I trying to use SysDVR 6.1, I found a strange thing. SysDVR 6.1.1, [SysDVR.zip] is 3.08MB, but SysDVR 6.1, [SysDVR.zip] is 12.8MB, SysDVR 6.1 had the same problem.

longruhai0901 commented 3 months ago

the SysDVR 6.1's UI abnormal

exelix11 commented 3 months ago

The difference in size is because of the fonts in the settings app, I started trimming the Chinese one which was huge to only have the characters we need.

The crash in internet settings as far as we know is caused by too many sysmodules or other mods

Rafacasari commented 3 months ago

The crash in internet settings as far as we know is caused by too many sysmodules or other mods

Even with only ldn_mitm and SysDVR modules, internet settings keep crashing. The only thing that fix it temporarily is to open the internet settings as soon you boot the switch, then will work until you restart it.

longruhai0901 commented 3 months ago

The crash in internet settings as far as we know is caused by too many sysmodules or other mods

Even with only ldn_mitm and SysDVR modules, internet settings keep crashing. The only thing that fix it temporarily is to open the internet settings as soon you boot the switch, then will work until you restart it.

Conflict is these two,maybe. But I set ldn_mitm to off, no effect. I'll turn off the ldn_mitm's background service later.

longruhai0901 commented 3 months ago

@exelix11 @RealHurrison I found it out! Use the DeepSea Toolbox to confirm the background services.
The ldn_mitm must be off when the SysDVR is on. Need to reboot.

longruhai0901 commented 3 months ago

I test like these:

  1. Only keep the background service for SysDVR on, internet setting is ok.
  2. Keep the background service for SysDVR and Tesla both on, Ok.
  3. The background service for SysDVR/ Tesla and ldn_mitm on, it's going wrong. According to these, I guess this issue comes from the SysDVR and ldn_mitm, because they all want to connect to pc.

When the the background service for ldn_mitm is off, we start ldn_mitm with the wrong which is "ldn_mitm is not loaded".

exelix11 commented 3 months ago

because they all want to connect to pc.

Unless you can track this down to an USB issue, I don't think it is accurate, it's more likely to be a memory usage issue.

Not sure about ldn mitm but for network stuff sysdvr uses regular socketing APIs so I don't see how can that cause settings to crash.

github-actions[bot] commented 3 weeks ago

This issue is stale because it has been open for 30 days with no activity.