exelix11 / SysDVR

Stream switch games to your PC via USB or network
GNU General Public License v2.0
1.39k stars 91 forks source link

Atmosphere crash when opening internet settings #295

Open Carlcooper opened 2 weeks ago

Carlcooper commented 2 weeks ago

Describe the bug When opening internet settings, the atmosphere cfw would crash.

To Reproduce Open the internet settings with SYS Dvr

Expected behavior Expected the internet settings applet to open.

Setup information

Additional context I found out the bug through renaming the sys module ID in the content folder.

exelix11 commented 2 weeks ago

Are you sure it's not a combination of other mods ? Try in a clean install of ams

ArcDelta commented 1 week ago

Atmosphere crashes under those cirumctances (in my own case) when having a theme installed. I don't know why it does happen under those circumstances or if there are more ways to trigger this crash on Atmosphere.

ArcDelta commented 1 week ago

I decided to delete the /atmosphere/contents/00FF0000A53BB665 folder (in other words, getting rid of SysDVR) and everything works fine with the themes, which means that the problem is a compatibility between the themes AND SysDVR (at least in my particular case).

exelix11 commented 1 week ago

I don't think anyone else has reported this same issue as you. Sysdvr is known to cause memory issues if you have other sysmodules. Of course themes have the same problem since they slightly increase memory usage. So I'd suggest trying a clean install of atmosphere and enabling things one at a time.

DefenderOfHyrule commented 1 week ago

Describe the bug When opening internet settings, the atmosphere cfw would crash.

To Reproduce Open the internet settings with SYS Dvr

Expected behavior Expected the internet settings applet to open.

Setup information

* Console firmware (17.0.0)

* Atmosphere 1.6.2

* SysDVR version (v1.0.11)

Additional context I found out the bug through renaming the sys module ID in the content folder.

Describe the bug When opening internet settings, the atmosphere cfw would crash.

To Reproduce Open the internet settings with SYS Dvr

Expected behavior Expected the internet settings applet to open.

Setup information

* Console firmware (17.0.0)

* Atmosphere 1.6.2

* SysDVR version (v1.0.11)

Additional context I found out the bug through renaming the sys module ID in the content folder.

This issue can have several causes, the main one being SysDVR in combination with ldn_mitm, (assuming this is error code 2162-0002 with program ID 0100000000001006). I haven't extensively looked into it yet but it has been happening since atmosphere 1.6.0+ iirc (as I am the "main" maintainer of ldn_mitm now I guess (?))

exelix11 commented 1 week ago

Is there a way to profile HOS memory pools to know if the cause really is too many sysmodules ? For sysdvr i really tried to reduce memory usage to the minimum possible, i link without malloc and the bottleneck are the socket and video capture buffers so i don't think this can ever be fixed.

DefenderOfHyrule commented 1 week ago

I don't personally know if there is a way to profile that but I doubt it's a RAM issue as it did work before atmosphere 1.6.0 as far as I can remember, it's likely not an issue with sysdvr/ldn_mitm either as they work independently but not when used together (maybe something regarding the priority of sysmodules? not sure if relevant at all, just mentioning it)

exelix11 commented 1 week ago

I don't track ams versions vs crash reports so really can't say. Did you try asking on reswitched ? Maybe someone there can at least point us to the right direction.

DefenderOfHyrule commented 1 week ago

I haven't tried asking in RS, I might do so later (unless you want to do so first) but it's a strange issue. I appreciate your replies

exelix11 commented 1 week ago

I didn't cause tbh i thought it was user error of having a messed up ams setup, i only received a couple of these crash reports. Go ahead and ask, make sure to ping me so i can follow the convo.