search

exelix11 / dvr-patches

System patches to stream most switch games with sysdvr
BSD 3-Clause "New" or "Revised" License
157 stars 2 forks source link

Does not work with The Witcher 3. #4

Open hhgokraken opened 3 years ago

hhgokraken commented 3 years ago

First, your work is awesome, thanks!

Second, I don't want to bother you with each game that I try to use with the patch and don't work (because just few doesn't, most of them worked like a charm), could you please provide some guidance to "what I could read/study" (I know how to program and are able to build Atmosphere with libnx) to create the .ips files to help (PR, as requested)?

Last, if the second is not possible, no problem, just want to let you know that this one "failed". Thank you.

suchmememanyskill commented 3 years ago

What do you mean with "failed"

hhgokraken commented 3 years ago

Means that the game didn't open when I enable the dvr-patch. If I remove the patch from /atmosphere/exefs_patches/, the game load normally. If I put back the am inside Atmosphere, this specific game, don't load.

Atmosphere don't crash. The game just don't load, fail and close. I guess that was something related to high memory usage: some games may have memory issues.

exelix11 commented 3 years ago

Are you using the updated patches i uploaded yesterday right ?

Second, I don't want to bother you with each game that I try to use with the patch and don't work

Actually i'd rather if you opened an issue for every game that doesn't work, specify name, version and if you can title id. That helps me and people using this patch tracking which games are broken.

high memory usage: some games may have memory issues.

Yeah that's most likely the problem, check if it produced a crash log and upload it here.

could you please provide some guidance to "what I could read/study" (I know how to program and are able to build Atmosphere with libnx) to create the .ips files to help (PR, as requested)?

For games that don't work with the generic patches i made there's no fixed way, you'd have to reverse engineer the game, figure out where it crashes from the crash report, trace the cause and if it's doable patch it in a way that doesn't crash. If the game just runs out of memory i don't think there's much to be done.

hhgokraken commented 3 years ago

Are you using the updated patches i uploaded yesterday right ?

Yes.

Actually i'd rather if you opened an issue for every game that doesn't work, specify name, version and if you can title id. That helps me and people using this patch tracking which games are broken.

Right, here we go:

Name: The Witcher 3 - Wild Hunt TID: 0100E67012924000 Update: 0100E67012924800, v65536

All DLCs and updates installed.

Yeah that's most likely the problem, check if it produced a crash log and upload it here.

The game just close, I will check the Atmosphere crash log to see if I find something.

For games that don't work with the generic patches i made there's no fixed way, you'd have to reverse engineer the game, figure out where it crashes from the crash report, trace the cause and if it's doable patch it in a way that doesn't crash. If the game just runs out of memory i don't think there's much to be done.

I see. I tried other memory eaters and worked. But I will continue doing tests and will open issues when I found something different.

rashevskyv commented 2 years ago

Witcher 3 is still crashed on the latest version of dvrpatches. Tested on Atmosphere 1.2.5 on 13.2 and 13.1

liuwudi0606 commented 2 years ago

@rashevskyv I have the same error with you when launching The Witcher 3.I have tried all ways to figure out the reason until I delete the AM file.I am glad to see that someone had fund the bug. @exelix11 Hope the author can fix it up thx！！

exelix11 commented 2 years ago

I did try to fix this game but it's not a simple patch like the others, as i'm not interested in 100% compatibility with games i'll just leave this one be. If anyone wants to contribute a patch for it feel free to do it.

zf021600 commented 2 years ago

Witcher 3 is still crashed on the latest version of dvrpatches. Tested on Atmosphere 1.2.6 on 13.2.1