Closed axtens closed 4 months ago
the earlier PR can be trashed. And "[no important files changed]" needs to be asserted
The Test check failed. Does this change actually fix the problem?
Doesn't the Test/ci always fail? (Because of the Input required and not supplied: token
) @ErikSchierboom ?
Yes, but I'm asking if this fixes the issue you reported in https://forum.exercism.org/t/cli-debugging-of-matching-brackets-throws-error-in-test-library/11530
If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
[no important files changed]
@ErikSchierboom a question: the test file is listed as an invalidator for each exercise. Which takes precedence, "no important files changed" or invalidators?
No important files changed
Doesn't the Test/ci always fail? (Because of the Input required and not supplied: token) @ErikSchierboom ?
Well, only when the PR is submitted from a fork. I therefore highly recommend not using a fork for PRs but to push branches directly to this repo and then PR from there.
Yes, but I'm asking if this fixes the issue you reported in https://forum.exercism.org/t/cli-debugging-of-matching-brackets-throws-error-in-test-library/11530
@axtens does it?
@glennj No, it does not fix the problem. In circular-buffer
I still get
$ bin/test-no-docker circular-buffer
Exception: Unknown l:: at line 68 byte 1615 in libs/exercism/test <- G:eval <- I:include?: task REPL
and that is AFTER having updated libs/exercism/test to include needs utils/latebind
on line 2.
I shall take this up with Ron.
And diff exercises/practice/bob/libs/exercism/test exercises/practice/circular-buffer/libs/exercism/test
shows no differences. bob's tests run flawlessly.
Got a reply from Ron https://8th-dev.com/forum/index.php?topic=2864.0;topicseen will fix tonight
Actually it might not be so easy as that's a change to a system library not one of ours.
@ErikSchierboom , how hard/easy would it be to edit a system library file in the 8th installation? We are due an update of the binary so I could make the change before I submit the zip file to you.
I've sent @ErikSchierboom the latest version of the interpreter with an updated latebind. Once that's in place I'll double-check the repo's tests.
@axtens The structure of the zip file is different from normal. I think you added a top directory that wasn't there. Could you fix?
Righto
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.
If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping
@exercism/maintainers-admin
in a comment. Thank you!