search

exercism / DEPRECATED.rikki-ruby-analyzer

Light wrapper around JacobNinja's codeminer for exercism project
2 stars 2 forks source link

Don't run shebang analyzer on test files #6

Closed budmc29 closed 7 years ago

budmc29 commented 7 years ago

That's the best solution I could figure, open to any suggestions.

kytrinyx commented 7 years ago

Thanks @budmc29! Please join us in

https://github.com/exercism/ruby/issues/295

to discuss whether the right choices is to remove the shebangs, or to ignore them in rikki-ruby-analyzer.

kotp commented 7 years ago

Strange display bug on this comment

kytrinyx commented 7 years ago

@kotp I'm not sure what you're referring to. Is the link the one you intended?

kotp commented 7 years ago

I tested the link, on a short display it works, a taller one, not so well, but it is this: "Thanks @budmc29! Please join us in Thanks @budmc29! Please join us in " where the duplication is not wanted, but in the text area of the post does not show that was intended, when you press "edit" icon, it shows: "Thanks @budmc29! Please join us in" and then continues on with the link.

Very strange.

kytrinyx commented 7 years ago

Oh, I see what you mean. I put the link on its own line and that seems to have fixed it. I'll report this at work if I can reproduce it.

kytrinyx commented 7 years ago

Per the discussion in exercism/ruby#295, we've decided to solve this by removing the shebang in the ruby tests. Closing this.

kytrinyx commented 7 years ago

Thanks, @budmc29, for taking the initiative to get this taken care of!

budmc29 commented 7 years ago

@Insti thanks for the suggestions.

@kytrinyx, happy to give back to this project, it has been very fun so far.