search

exercism / DEPRECATED.v2-feedback

Please use https://github.com/exercism/exercism.io for reporting issues
13 stars 5 forks source link

Separate 'Complete Exercise' from 'Comment' button #187

Closed MarcosX closed 6 years ago

MarcosX commented 6 years ago

When writing a comment the 'Complete Exercise' button bellow the text area is highlighted and may induce people to clicking on it while trying to submit a comment, specially since the 'Comment' button looks like a "secondary button".

screen shot 2018-06-27 at 13 37 02

I think that maybe the two buttons could be placed differently on the screen, maybe above the 'Mentor Discussion' section or something (I'm not an UX person so there are probably better ways to achieve this :p),

iHiD commented 6 years ago

Which page is this on?

I think this is on your own solution where the mentor has approved your exercise and therefore the primary action is to complete the exercise. Could you send me a full-screen screenshot pls?

iHiD commented 6 years ago

Just seen #186. Maybe we should move that button from there altogether. I remember we struggled with where to put it because there's already a few CTAs. I wonder about maybe not showing the comment box by default once the exercise has been approved and instead having two buttons for Complete and a secondary action for adding a comment, which shows the box. We'll discuss internally. Thanks.

iHiD commented 6 years ago

I've now separated this button out (on master).

screen shot 2018-07-01 at 14 48 01

Thanks for the super-helpful suggestions!