exercism / DEPRECATED.v2-feedback

Please use https://github.com/exercism/exercism.io for reporting issues
13 stars 5 forks source link

mentorcism: Walkthrough, installing CLI on Mac manually #192

Closed rpottsoh closed 6 years ago

rpottsoh commented 6 years ago

@rpottsoh commented on Fri Jun 22 2018

image

The releases page link does not appear to cause a new browser tab to open. I must qualify my remark by stating that I am testing this with chrome on a Windows computer. I am assuming the link behaves the same way on a Mac.

It would be better I think if clicking the link would trigger a new browser window to open to the releases page instead of taking the user away from the site in the middle of the walk through.

This should accomplish the task:

<a href="https://github.com/exercism/cli/releases/latest" target="_blank">https://github.com/exercism/cli/releases/latest</a>

@rpottsoh commented on Fri Jun 22 2018

I didn't examine this point on the Linux path. It likely would also benefit from this improvement.


@kytrinyx commented on Fri Jun 22 2018

Nice, good catch. Thanks!


@rpottsoh commented on Sun Jul 01 2018

@kytrinyx I'd be happy to open a PR for this, however I have discovered I can no longer get bundle exec rake compile to work. I cannot get libv8 to compile, therubyracer is dependent on it. I know what changes to make to the *.tw2 files, just won't be able to check my changes...


@iHiD commented on Sun Jul 01 2018

@rpottsoh I actually think the best place to make this change is in the website and make a global rule for it for all links. Would you mind creating an issue on v2-feedback that points to this issue and I'll triage and get it sorted before launch from there pls. I'd do it myself but I'm on my way to bed :)

rpottsoh commented 6 years ago

@iHiD not exactly what you asked for,but I hope just as satisfactory.

iHiD commented 6 years ago

Smooth. Thanks!

kytrinyx commented 6 years ago

This repo is being deprecated. We've imported this issue to the https://github.com/exercism/exercism.io repository.