search

exercism / automated-analysis

An overview space for Automated Analysis on Exercism
26 stars 13 forks source link

[Update To Deploy] C# #74

Closed ErikSchierboom closed 5 years ago

ErikSchierboom commented 5 years ago

Please deploy the latest C# analyzer. It doesn't use tags at the moment, so the deploy can be made from the master branch.

ccare commented 5 years ago

Hi @ErikSchierboom , I gave it a go, but when I pushed it live (and replayed a couple of solutions) things just started to fail, so I rolled back.

image

ccare commented 5 years ago

Looking at it, it looks like it might be a simple fix, I got this error in the logs

container_linux.go:344: starting container process caused "exec: \"bin/analyze.sh\": permission denied"
raw_output.err (END)
ErikSchierboom commented 5 years ago

Ah, the shell script did not have an executable bit set. Sorry about that!

I've just pushed a new commit that fixes this. Hopefully this will solve the issue.

ccare commented 5 years ago

Hi @ErikSchierboom, sorry for the delay, but I've shipped that and it looks good to me now. Are there any specific examples/solutions I should try and and replay as a smoke test?

Feel free to close this issue if you're happy :)

ErikSchierboom commented 5 years ago

Awesome! Could you replay https://exercism.io/mentor/analyses/19131?

ccare commented 5 years ago

It looks good to me. Here are the before/after states before the replay.

{
  "status": "disapprove",
  "comments": [
    {
      "params": {
      },
      "comment": "csharp.general.has_compile_errors"
    }
  ]
}
{
  "status": "disapprove",
  "comments": [
    {
      "params": {
        "name": "Speak",
        "signature": "public static string Speak(string name)"
      },
      "comment": "csharp.general.invalid_method_signature"
    },
    {
      "params": {
      },
      "comment": "csharp.two-fer.use_single_formatted_string_not_multiple"
    },
    {
      "params": {
        "name": "kisi"
      },
      "comment": "csharp.two-fer.use_default_value"
    }
  ]
}
ccare commented 5 years ago

@ErikSchierboom does that mean it's OK now?

ErikSchierboom commented 5 years ago

@ccare Yep, it's ok then!