[Update To Deploy] Java analyzer

[Smarticles101]

Please deploy the latest Java analyzer on the master branch. We've just merged an analyzer for the hamming exercise and will add comments shortly.

[jmrunkle]

May want this to wait until https://github.com/exercism/website-copy/pull/1262 actually goes in otherwise the comments will not be in place.

[Smarticles101]

no, the comments are updated independently from the analyzer iirc

[iHiD]

Hi both. So the comments need to be in place before the analyzer is deployed, else the analyses will error (due to missing comments). Saying that, erroring doesn't really have massive side-effects. The only real thing is that for disapprove comments, the mentors might not understand why it's being disapproved and what to do if the comments are missing.

[jmrunkle]

Thanks for confirming - that was what I recalled when we were deploying the twofer analyzer.

[ccare]

I've built the image for this, so whenever the comments are merged, it'll be good to release.

[SleeplessByte]

@ccare good to go! I just merged it in.

[jmrunkle]

Thanks @SleeplessByte - @ccare just update once you release it so that I can check the analyses dashboard.

[ccare]

@jmrunkle I've deployed this, and re-run a few analyses through - all looking good so far (no change or breaks for existing exercises :) ).

There are 30ish hamming iterations that are in a good state to be sent through the analyser, these should provide a good smoke test. However, before that'll work, we'll need a quick PR on here https://github.com/exercism/analyzer-orchestrator/blob/59af78310f8cb9cb3487d3b6f3294a0354366321/lib/orchestrator/analyze_iteration.rb#L12 to enable the exercise for static analysis. I can prepare and release that, but figured you might want to be control when this gets enabled. Let me know what you want to do.

[jmrunkle]

@ccare Feel free to proceed (I know we are in different timezones anyway). I don't need manual control over when it gets enabled.

[ccare]

Cool! I will let you know how it goes.

On Mon, Sep 2, 2019 at 4:38 PM Jason Runkle notifications@github.com wrote:

@ccare https://github.com/ccare Feel free to proceed (I know we are in different timezones anyway). I don't need manual control over when it gets enabled.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/exercism/automated-analysis/issues/75?email_source=notifications&email_token=AADLWQTLI3GWEMOEIQXYRSDQHUXPDA5CNFSM4IQEJVKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5WD7OQ#issuecomment-527187898, or mute the thread https://github.com/notifications/unsubscribe-auth/AADLWQV46FIRQ3C5JXEF5DTQHUXPDANCNFSM4IQEJVKA .

[jmrunkle]

Also, is there something we need to do to run it against the existing queue? I assume that is part of the process, but just wanted to be certain.

[iHiD]

Also, is there something we need to do to run it against the existing queue?

@ccare I think you have a script to do this, but let me know if not and I'll put one together for you

[ccare]

There is indeed a script for this... it resides at https://github.com/exercism/scripts/blob/master/publish_batch_to_analyze.rb and very good it is too :)

@Smarticles101, @jmrunkle I've re-run them through, and it's all looking great! Thanks all.

Given that I've seen the analyser happily returning all the various states, I'll close this issue now, but do reopen if you think anything needs is wrong. Thanks again.

[jmrunkle]

I just checked it over myself and the analyses seem to be correct. Thanks!

[ccare]

Cool!

On Wed, 4 Sep 2019, 15:47 Jason Runkle, notifications@github.com wrote:

I just checked it over myself and the analyses seem to be correct. Thanks!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/exercism/automated-analysis/issues/75?email_source=notifications&email_token=AADLWQVCFQC5YE7Q7GRGM4DQH7C7RA5CNFSM4IQEJVKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD532LZQ#issuecomment-527934950, or mute the thread https://github.com/notifications/unsubscribe-auth/AADLWQSPDVVDRDFHLTFQPG3QH7C7RANCNFSM4IQEJVKA .