search

exercism / bugs

Please use https://github.com/exercism/exercism for reporting bugs.
1 stars 3 forks source link

Smalltalk: Formatting single-quote-character is not a string #25

Open bencoman opened 5 years ago

bencoman commented 5 years ago

Which source-formatting library does Exercism currently use? The Smalltalk formatter has an error handling string-quote-character definition... $' It is treating it as a start-string-indicator and formatting all subsequent text as a string, when really the dollar-sign acts similar to blackslash-escape to define the character itself.

Line 23-24 here is an example... https://exercism.io/mentor/solutions/0db14c4c5111427ab0afd311b2ae4fa7 Line 24 should not be green.

I'll follow up the formatting-library if you can point me in the right direction.

iHiD commented 5 years ago

If you could try it here that will narrow down whether it's an issue with Prism (the formatting library we use) or whether it's an issue with us. Thanks :)

bencoman commented 5 years ago

Thx (I should have remembered)

Here is Exercism (line 24 should not be green)... image

Here is Prism test site (is correct)... image

It may have been fixed incidently by this other issue I reported... https://github.com/PrismJS/prism/issues/1746

It looks like that was released in PrismJS-1.16.0 (2019-03-24). What version is Exercism on?

iHiD commented 5 years ago

@kntsoriano Another prism one for you :)

bencoman commented 5 years ago

Even though the PrismJS test site was working, I noticed it was missing an explicit test for this, which I added... https://github.com/PrismJS/prism/pull/2041/files#diff-06f06b53e36d57af53b97bd66ac84ed9R1-R13 with a minor change to prioritize Character above String.

kntsoriano commented 5 years ago

The Prism site is on the latest version that hasn't been released yet. I'm also unsure when the Prism team would release.

iHiD commented 5 years ago

OK, cool. Let's keep an eye on it. @bencoman If you notice it gets released, ping us here and we'll upgrade it :)