search

exercism / c-test-runner

GNU Affero General Public License v3.0
5 stars 5 forks source link

Update process_results_file path #58

Closed yorange1 closed 2 years ago

yorange1 commented 2 years ago

Do not specify the path to process_results.py, so that c-test-runner can be placed in other directory.

wolf99 commented 2 years ago

Do other tracks' test runners do this?

I.e. is it really needed?

yorange1 commented 2 years ago

I'm not sure, I just found this issue while trying to fix the color tests issue. At the time I just cloned the code and followed the instructions in the README.md to try to run the test runner.

I think other people may have this problem too, so I want to fix it.

ErikSchierboom commented 2 years ago

Do other tracks' test runners do this?

I.e. is it really needed?

I don't think they do. I think the main reason for this is that most test runners only really work within their Docker image, so there is no real downside to having the path hardcoded. That said, if the C test runner can run locally and the change still works for the Docker image, 🤷

yorange1 commented 2 years ago

As I did, the change makes it convenient to run and develop the runner locally without docker. Meanwhile, the change still works for the Docker image.

In addition, I found python test runner is not using hardcoded paths. image