search

exercism / c

Exercism exercises in C.
https://exercism.org/tracks/c
MIT License
273 stars 176 forks source link

Return type for `convert(char result[], int drops)` in "Raindrop" should be of type `void` #968

Closed Ashvith10 closed 3 months ago

Ashvith10 commented 3 months ago

Since the test cases do not make use of returned value, and it is clear from the overview that the argument is used to pass the string by reference, it makes sense to use void instead. Learners might be confuse this behavior.

wolf99 commented 3 months ago

I'm ok with this. Would you like to make a PR with this change @Ashvith10 ?

Ashvith10 commented 3 months ago

@wolf99 I've created a PR for the same.