search

exercism / clojure-representer

GNU Affero General Public License v3.0
1 stars 5 forks source link

Output file with representer version #35

Closed bobbicodes closed 1 year ago

bobbicodes commented 1 year ago

I was reviewing the spec to see if there was anything I missed because the representer does not seem to be live yet. I'm not sure if this would be the issue (it says the version defaults to 1 anyway) but now it outputs the file.

bobbicodes commented 1 year ago

What made you think the representer isn't live?

Oh cool, so they're being generated, but I still can't find them. It's supposed to be in the Mentoring tab right? I can see all the occurrences for the other languages but not Clojure.

ErikSchierboom commented 1 year ago

Yes, but there is an additional requirement: the representations must have > 1 matching submissions (http://forum.exercism.org/t/building-the-clojure-representer-coming-in-for-a-landing/664/12)

bobbicodes commented 1 year ago

I saw your response, but I'm still confused because I've submitted matching solutions from 2 different accounts. And besides... if it ran all the solutions retroactively there should be dozens of them. For example, there is a representation for two-fer that occurs 114 times out of the last 500.

ErikSchierboom commented 1 year ago

if it ran all the solutions retroactively there should be dozens of them

If being the keyword here, as currently we don't do that. I'll look into it, but I'm quite swamped right now so I don't know exactly know when

ErikSchierboom commented 1 year ago

@BTowersCoding The representer is erroring. I'll try and find out why

ErikSchierboom commented 1 year ago

=> "docker: Error response from daemon: OCI runtime create failed: container_linux.go:380: starting container process caused: exec: \"/opt/representer/bin/run.sh\": permission denied: unknown.\n"

That's the error. I'll do more digging if I find the time

ErikSchierboom commented 1 year ago

See https://github.com/exercism/clojure-representer/pull/36

bobbicodes commented 1 year ago

Aha! That makes sense because that script doesn't get run in testing. Thanks!

ErikSchierboom commented 1 year ago

Hmmm, it's weird. That doesn't fix it. I'm looking into it

ErikSchierboom commented 1 year ago

Still doesn't seem to work. So weird! I can't reproduce locally.

ErikSchierboom commented 1 year ago

@BTowersCoding I've downloaded the latest representer docker image locally and ran it via the website, and got this error:

Execution error (FileNotFoundException) at java.io.FileInputStream/open0 (FileInputStream.java:-2).
/mnt/exercism-iteration/hello_world.clj (No such file or directory)

Full report at:
/tmp/clojure-12457495797171459648.edn

I think the issue is that the file should actually be found at /mnt/exercism-iteration/src/hello_world.clj (missing /src before hello_world.clj.

bobbicodes commented 1 year ago

I think the issue is that the file should actually be found at /mnt/exercism-iteration/src/hello_world.clj (missing /src before hello_world.clj.

Ah, that makes sense! It indeed expects the solution file to be in the input directory. I'll make the change and update the tests. See: #37