search

exercism / coffeescript

Exercism exercises in CoffeeScript.
https://exercism.org/tracks/coffeescript
MIT License
19 stars 50 forks source link

fix protein-translation tests #265

Closed ladokp closed 5 months ago

ladokp commented 5 months ago

After failing the test like commented here #259 this is the only oddity I found in the tests. @BNAndras, @ErikSchierboom: Can this be the solution to successfully submit the exercise?

github-actions[bot] commented 5 months ago

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

ladokp commented 5 months ago

Okay, the pipeline failed. This is not the solution. :-(

ladokp commented 5 months ago

rewrote the last test to check for an exception and not a string like seen in other exercise tests. Hope this will solve the issue on submitting the exercise.

ErikSchierboom commented 5 months ago

What's your code?

ladokp commented 5 months ago

Github did not pull my latest commit when PR is closed I assume.

ladokp commented 5 months ago

created new PR with current code: #266

BNAndras commented 5 months ago

That snippet was modified from queen-attack so you may want to check that test suite too.

ladokp commented 5 months ago

Okay, I'll check that too.

BNAndras commented 5 months ago

I must have misunderstood the examples for toThrow on https://jasmine.github.io/api/edge/matchers.html where it looks like we're passing in the expected error message. Perhaps toThrowError beneath it would be better. We can just specify the expected message.

ladokp commented 5 months ago

I hope my fix in #266 should work. It's also based on another exercise's test.

ladokp commented 5 months ago

The queen-attack tests are still successful. 🤔 So no error there.