exercism / coffeescript

Exercism exercises in CoffeeScript.
https://exercism.org/tracks/coffeescript
MIT License
19 stars 50 forks source link

bob: Update to clarify ambiguity regarding shouted questions #90

Closed kytrinyx closed 11 months ago

kytrinyx commented 6 years ago

TL;DR: the problem specification for the Bob exercise has been updated. Consider updating the test suite for Bob to match. If you decide not to update the exercise, consider overriding description.md.


Details

The problem description for the Bob exercise lists four conditions:

There's an ambiguity, however, for shouted questions: should they receive the "asking" response or the "shouting" response?

In https://github.com/exercism/problem-specifications/pull/1025 this ambiguity was resolved by adding an additional rule for shouted questions.

If this track uses exercise generators to update test suites based on the canonical-data.json file from problem-specifications, then now would be a good time to regenerate 'bob'. If not, then it will require a manual update to the test case with input "WHAT THE HELL WERE YOU THINKING?".

See the most recent canonical-data.json file for the exact changes.

Remember to regenerate the exercise README after updating the test suite:

configlet generate . --only=bob --spec-path=<path to your local copy of the problem-specifications repository>

You can download the most recent configlet at https://github.com/exercism/configlet/releases/latest if you don't have it.

If, as track maintainers, you decide that you don't want to change the exercise, then please consider copying problem-specifications/exercises/bob/description.md into this track, putting it in exercises/bob/.meta/description.md and updating the description to match the current implementation. This will let us run the configlet README generation without having to worry about the bob README drifting from the implementation.

kytrinyx commented 6 years ago

I've submitted a PR to temporarily lock the description of 'bob' so that we can regenerate the exercise READMEs without worrying about getting an out-of-sync description.

This means that the exercises/bob/.meta/description.md file will need to be deleted if the test suite is updated to include the new rule.

safwansamsudeen commented 11 months ago

@ErikSchierboom after #229 is merged, this can be closed.