search

exercism / configlet

The official tool for managing Exercism language track repositories.
https://exercism.org/docs/building/configlet
GNU Affero General Public License v3.0
22 stars 14 forks source link

fetch-configlet: support fetching arm64 assets #805

Closed ee7 closed 1 year ago

ee7 commented 1 year ago

The most recent configlet release includes pre-built binaries for:

Support arm64 in the bash fetch-configlet script.

Refs: #122 Follow-up from: https://github.com/exercism/configlet/issues/764#issuecomment-1685080166

I'll change the logic in this script in a later PR. I think we shouldn't hardcode the available binaries in the fetch scripts. Instead, we should try to download the configlet release for the user's machine, and error if the asset does not exist. Then we can add assets to the configlet releases without updating the fetch scripts on every track. That'll also make the fetch script support riscv64 Linux.

I suggest delaying the Exercism-wide PRs until we've done that.

ee7 commented 1 year ago

CI failure should be resolved by https://github.com/exercism/configlet/pull/806.

ee7 commented 1 year ago

@ErikSchierboom I'll leave updating the PowerShell script to you. But let's do that in a separate PR.

Currently:

https://github.com/exercism/configlet/blob/dca4119e22667d562270f4ca4f7ab545ee79e302/scripts/fetch-configlet.ps1#L15-L16

I think it should also probably have the same logic change that I suggest in the top post. But it's less important.

I suspect that we don't have a huge number of non-Windows PowerShell users, but we could consider resolving https://github.com/exercism/configlet/issues/361 at the same time.