search

exercism / cpp

Exercism exercises in C++.
https://exercism.org/tracks/cpp
MIT License
257 stars 211 forks source link

Update introduction.md #697

Closed pdmoore closed 1 year ago

pdmoore commented 1 year ago

Fix typos in the Assignment Operators section.

github-actions[bot] commented 1 year ago

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

pdmoore commented 1 year ago

Thanks for the quick turnaround on this! Agreed on the revamp. I wanted to separate the simple fix from a larger change. I think there should be mention of operations in parentheses taking precedence over left-to-right order. The solution also seems to require std:ceil but doesn't cover floor vs ceiling rounding. This exercise also explains using an apostrophe to separate digits which would have been better placed in an earlier exercise in the syllabus, Last Will, which uses that notation without any mention of it.

vaeng commented 1 year ago

Thanks for the quick turnaround on this!

Thanks for opening a PR!

Agreed on the revamp. I wanted to separate the simple fix from a larger change. I think there should be mention of operations in parentheses taking precedence over left-to-right order. The solution also seems to require std:ceil but doesn't cover floor vs ceiling rounding.

I merged the fixes for the typo, there might be other places that have the same texts, I will try to correct those as well. Generally there is the introduction from the concept, which is reused in the about and again in each exercise that uses the concept. Three times the work. I would be happy to automate that bit with templates.

This exercise also explains using an apostrophe to separate digits which would have been better placed in an earlier exercise in the syllabus, Last Will, which uses that notation without any mention of it.

Good point. I was sure I had those in the right order, I have to check the config.json if there was a mix-up somewhere.

pdmoore commented 1 year ago

I merged the fixes for the typo, there might be other places that have the same texts, I will try to correct those as well.

I wasn't aware of the duplication - will keep it in mind for the future.

For this particular set of typos they also need fixing in: exercises/concept/freelancer-rates/.docs/introduction.md ./concepts/numbers/about.md