exercism / cpp

Exercism exercises in C++.
https://exercism.org/tracks/cpp
MIT License
257 stars 211 forks source link

Strengthen tests in Vehicle Purchase exercise #700

Closed pdmoore closed 1 year ago

pdmoore commented 1 year ago

Current tests for choose_vehicle allow a simplistic implementation of return option1 + " is clearly the better choice."; to pass all tests without comparing option1 and option2.

This is due to the current tests all passing in option1 and option2 sorted in lexicographic order already.

This change swaps option1 and option2 for a couple of the tests which forces the implementation to compare the parameters.

This change will not impact existing solutions that are correctly implemented.

github-actions[bot] commented 1 year ago

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.