search

exercism / cpp

Exercism exercises in C++.
https://exercism.org/tracks/cpp
MIT License
254 stars 207 forks source link

Fixed incorrect type declaration in Introduction Docs #706

Closed BelaBartok39 closed 1 year ago

BelaBartok39 commented 1 year ago

Fixed a non-issue typo. In "introduction" docs for Ellens_Alien_Game , the term "inc" is used instead of declaring an "int". Could be very confusing for a beginner.

github-actions[bot] commented 1 year ago

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

siebenschlaefer commented 1 year ago

Yes, this is obviously a typo. Good catch! Usually we want to discuss PRs on the forum first but this is a minor change that doesn't need any discussion.
In cases like this we usually reopen the PR and merge it. But you deleted your fix-typo-ellens-alien-game-docs branch so that's no longer possible. If you want you could submit a new PR, we well reopen and merge it. Or we can fix the typo ourselves. Thanks!

BelaBartok39 commented 1 year ago

Hello! Yes, I thought the same thing. Such a small obvious typo might not need a full PR template. I read the Contributing docs. I have more to fix but when I went to open the first pull request I got a message saying that all Pull Requests are being closed automatically and Exercism is no longer accepting contributing PRs. I was bummed because I have quite a bit I wanted to add/fix! I hope you all get the time to catch up like you mentioned. I will resubmit the basic typo fix PR. Thank you for the quick reply!

vaeng commented 10 months ago

This has been fixed but is still persistent in the docs of the concept. -> #737