clock: the test timed out

nozomirin commented 11 months ago

This is my solution.

#if !defined(CLOCK_H)
#define CLOCK_H
#include <string>
namespace date_independent {
    class clock {
    public:
        clock(int hour, int minute);  
        static clock at(int hour, int minute);
        operator std::string() const;
        clock& plus(int minutes);
        bool operator==(clock &rhs) noexcept;
        bool operator!=(clock &rhs) noexcept;
    private:
        int hour_;
        int minute_;
    };
}  // namespace date_independent

#endif // CLOCK_H

#include "clock.h"
#include <cmath>
namespace date_independent {
clock::clock(int hour, int minute): hour_(hour), minute_(minute) {

}
clock clock::at(int hour, int minute) {
    int actual_hour = ( hour + static_cast<int>(std::floor(minute / 60.0)) ) % 24;
    int actual_minute = minute % 60;
    return clock(actual_hour, actual_minute);
}

clock::operator std::string() const {
    std::string hour = std::to_string(hour_);
    if (hour_ < 10) {
        hour = "0" + hour;
    }
    std::string minute = std::to_string(minute_);
    if (minute_ < 10) {
        minute = "0" + minute;
    } 
    return hour + ":" + minute ;
}

clock& clock::plus(int minutes) {
    int hour = std::floor(minutes / 60.0);
    int minute = minutes % 60;
    hour_ = (hour + hour_ + (minute + minute_) / 60) % 24;
    minute_ = (minute + minute_) % 60;
    return *this;
}

bool clock::operator==(clock &rhs) noexcept {
    return this->hour_ == rhs.hour_ && this->minute_ == rhs.minute_;
}

bool clock::operator!=(clock &rhs) noexcept {
    return !this->operator==(rhs);
}

}  // namespace date_independent

When I ran tests, it timed out. I tried to comment out these member functions, and I found the at function is the problem. But it seems that there is nothing special in this static member function (I searched other people's solutions and can't find something useful. I even copied someone's code and it just worked. I also paste them in godbolt.org and it compiled.)

Please forgive me if I miss something stupid.

github-actions[bot] commented 11 months ago

Hello. Thanks for opening an issue on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

Note: If this issue has been pre-approved, please link back to this issue on the forum thread and a maintainer or staff member will reopen it.

nozomirin commented 11 months ago

I know why it is not right now. The behavior of the modulo operation in c++ is not the same as python. I'm sorry for the disturbance.

siebenschlaefer commented 11 months ago

Great to hear that you could solve the problem.

For anybody else: I think the reason why the tests do time out is that in this solution the operator== and operator!= cannot be called with const objects. But our testing framework Catch2 does some complex meta-programming magic and the evaluation of REQUIRE(clock1 == clock2); and REQUIRE(clock1 != clock2); causes lots and lots of error messages, too many for our test runner to handle.

nozomirin commented 11 months ago

Both const for parameter and for function are necessary. It takes me so much time...

exercism / cpp

clock: the test timed out #723