search

exercism / cpp

Exercism exercises in C++.
https://exercism.org/tracks/cpp
MIT License
252 stars 205 forks source link

Update introduction.md #772

Closed ilmoro93 closed 6 months ago

ilmoro93 commented 6 months ago

Corrected wrong vector declaration

github-actions[bot] commented 6 months ago

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

ilmoro93 commented 6 months ago

Corrected introduction.md in making-the-grade.

However in your comment when I click on 652b20d I see a change about TEST_CASE("Alien is always hit", "[task_2]"). Is this an error with the link?

Would you please also change this in the respective exercise?

https://github.com/exercism/cpp/blob/652b20daaab508e2169f8586583ddadd73d6bbe8/exercises/concept/making-the-grade/.docs/introduction.md?plain=1#L31

vaeng commented 6 months ago

Woudl you please patch

Is this an error with the link?

No, that's fine. I just grabbed the link for the line from another branch, sorry.