search

exercism / cpp

Exercism exercises in C++.
https://exercism.org/tracks/cpp
MIT License
252 stars 205 forks source link

update triangle tests #787

Open DebbieSan opened 6 months ago

DebbieSan commented 6 months ago

Hello,

I followed the guide to synch and update the tests for the triangle exercise. I am not sure if there is another part to this process. If yes, please advise.

Thank you kindly!

github-actions[bot] commented 6 months ago

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

vaeng commented 4 months ago

Would you be so kind and add the uuids from the toml file to the tests and change the names of the cpp test files so they match the toml file as well? Here is an example: https://github.com/exercism/cpp/blob/main/exercises/practice/allergies/allergies_test.cpp

I can do it, if you don't want to spend more time on this. I know it can be exhausting to change so many things one by one.

DebbieSan commented 4 months ago

hi @vaeng for sure, I will do it :) thank you.

DebbieSan commented 4 months ago

Hi @vaeng, I added the UUIDs and updated the names, a couple of the tests I was unsure as they did not seem to match the toml file. Please advise and thank you kindly for your assistance.