search

exercism / cpp

Exercism exercises in C++.
https://exercism.org/tracks/cpp
MIT License
257 stars 212 forks source link

Sync hamming tests to problem-description data (#775) #789

Closed ahans closed 8 months ago

ahans commented 8 months ago

As discussed in #784, I was also confused about the include = false lines. The way I understand it, in canonical-data.json test cases are updated by adding a new version and a reimplements field that references the old version in the file. The old version is left untouched. I can imagine this is done to better be able to follow the edit history. But this also means that obsolete tests should not be part of the implementation. So that is what I have done here.

github-actions[bot] commented 8 months ago

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

vaeng commented 8 months ago

We can surely discuss this on the forums. Please note, that it would be better to have uuids as well in the test.cpp file, so they are easier to compare.

ahans commented 8 months ago

We can surely discuss this on the forums. Please note, that it would be better to have uuids as well in the test.cpp file, so they are easier to compare.

I added a comment with the UUID before each test case (there were none before). What else did you have in mind?

Update: Alright, I just saw the updated comments for anagram and that tags are used there. That's certainly better. I will adopt the same format here.

ahans commented 8 months ago

This has been updated.