exercism / cpp

Exercism exercises in C++.
https://exercism.org/tracks/cpp
MIT License
251 stars 205 forks source link

Feature/sync gigasecond #810

Closed ahans closed 4 months ago

github-actions[bot] commented 4 months ago

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

ahans commented 4 months ago

@exercism/cpp here is the new PR. I had forced-pushed to the previous to include the no important files changed tag. I wasn't aware that this would prevent re-opening. Sorry about that!

SleeplessByte commented 4 months ago

The failed check says:

This PR touches files which potentially affect the outcome of 
the tests of an exercise. This will cause all students' solutions
to affected exercises to be re-tested.

If this PR does **not** affect the result of the test (or, for
example, adds an edge case that is not worth rerunning all tests
for), **please add the following to the merge-commit message**
which will stops student's tests from re-running. Please
copy-paste to avoid typos.

[no important files changed]


For more information, refer to the [documentation](https://exercism.org/docs/building/tracks#h-avoiding-triggering-unnecessary-test-runs). 
If you are unsure whether to add the message or not, please ping
`@exercism/maintainers-admin` in a comment. Thank you!

In this case ya probably want to re-run all the student solutions.

ahans commented 4 months ago

In this case ya probably want to re-run all the student solutions.

I only added that one excluded test to tests.toml and renamed the tests. I didn't change any actual test code. The changes there are only formatting (looks like .clang-format has changed in the meantime or hadn't been applied to that file before). So I'm not sure we should really re-run all student solutions. However, I can of course drop the tag. Let me know what to do!

SleeplessByte commented 4 months ago

I didn't see the include false on the last line. If no tests were added (or changed) then indeed, it should NOT re-run ;)

[fcec307c-7529-49ab-b0fe-20309197618a]
description = "does not mutate the input"
include = false