search

exercism / cpp

Exercism exercises in C++.
https://exercism.org/tracks/cpp
MIT License
251 stars 205 forks source link

feat: add `pig-latin` practice exercise #811

Closed ahans closed 4 months ago

ahans commented 4 months ago

I'm not entirely happy with the example implementation yet.

github-actions[bot] commented 4 months ago

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

vaeng commented 4 months ago

Oh, no. I did not read that! Sorry. I also made a PR for that: #812

ahans commented 4 months ago

Oh, no. I did not read that! Sorry. I also made a PR for that: #812

Well, my bad for not mentioning that properly. Your call which one to keep. I think my implementation is more generic. I would have few comments how to make yours slightly more efficient as well.

vaeng commented 4 months ago

Oh, no. I did not read that! Sorry. I also made a PR for that: #812

Well, my bad for not mentioning that properly. Your call which one to keep. I think my implementation is more generic. I would have few comments how to make yours slightly more efficient as well.

I'd be happy to see your suggestions. Let's make it a double :)