search

exercism / cpp

Exercism exercises in C++.
https://exercism.org/tracks/cpp
MIT License
251 stars 205 forks source link

parallell-letter-frequency tests are missing some assertions #831

Closed ahans closed 4 months ago

ahans commented 4 months ago

The tests for the cases that expect an empty map as result are missing the assertions.

The script that I used to generate that code would iterate over the dict and was missing the "empty dict" special case. :(

github-actions[bot] commented 4 months ago

Hello. Thanks for opening an issue on Exercism 🙂

At Exercism we use our Community Forum, not GitHub issues, as the primary place for discussion. That allows maintainers and contributors from across Exercism's ecosystem to discuss your problems/ideas/suggestions without them having to subscribe to hundreds of repositories.

This issue will be automatically closed. Please use [this link](https://forum.exercism.org/new-topic?title=parallell-letter-frequency%20tests%20are%20missing%20some%20assertions&body=The%20tests%20for%20the%20cases%20that%20expect%20an%20empty%20map%20as%20result%20are%20missing%20the%20assertions.%0D%0A%0D%0AThe%20script%20that%20I%20used%20to%20generate%20that%20code%20would%20iterate%20over%20the%20dict%20and%20was%20missing%20the%20%22empty%20dict%22%20special%20case.%20:(&category=cpp ) to copy your GitHub Issue into a new topic on the forum, where we look forward to chatting with you!

If you're interested in learning more about this auto-responder, please read this blog post.

ahans commented 4 months ago

Fix is here: https://github.com/exercism/cpp/pull/830 (I only opened this because I expected that issues would not be automatically closed ...)