search

exercism / cpp

Exercism exercises in C++.
https://exercism.org/tracks/cpp
MIT License
256 stars 212 forks source link

Updated Phone-Number Test cases ( tests.toml & phone_number_test.cpp) #867

Closed tanno1 closed 5 months ago

tanno1 commented 5 months ago

first PR here.

used configlet to update tests.toml for phone numbers against the problem-specifications reqs, then went through problem-specs repo, tests.toml, and phone_number_test.cpp and updated cases accordingly to include the correct cases.

github-actions[bot] commented 5 months ago

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

tanno1 commented 4 months ago

Just realized I need to make some updates in the TEST_CASE() function and add in the UUIDs. I looked through previously merged commits and saw that. I will update and re pr tonight.