search

exercism / cpp

Exercism exercises in C++.
https://exercism.org/tracks/cpp
MIT License
256 stars 212 forks source link

Updated .toml & test cases to match problem specifications repo for phone numbers exercise #870

Closed tanno1 closed 4 months ago

tanno1 commented 4 months ago

third revision of my first pr here lol. the reason for this pr was originally from issue #775, and contains the updates that @vaeng was asking for in that issue. i references other pr's from that issue in my updates. let me know if there are questions or things i need to change.

github-actions[bot] commented 4 months ago

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

vaeng commented 4 months ago

Thanks for submitting that PR. You have opened three pull requests for the same task. This is a bit confusing as a maintainer. Is there a reason, why you did not re-use the ones you have started?

Please see the clang formatting suggestions, to pass the initial check.

tanno1 commented 4 months ago

@vaeng sorry for the confusion with multiple PRs, I didn't know that I could keep updating the same with new pushes, learning a lot. This PR is the only one I will be focusing on now and I will push changes to it.

I updated the formatting, is there a way I can run the initial check? I don't see it happening automatically when I push new code so I am assuming it requires some kind of approval from you?

tanno1 commented 4 months ago

can you run the reviews again @vaeng, from the root with the .clang-format file I ran "clang-format -i /path/to/test_file.cpp" this time and afaik that should be formatting correctly based off of the .clang-format file?

tanno1 commented 4 months ago

checks have passed, is there anything else I need to change here before it can be merged @vaeng?

vaeng commented 4 months ago

@tanno1 sorry for the delay, I will have time tomorrow to check your commits