search

exercism / cpp

Exercism exercises in C++.
https://exercism.org/tracks/cpp
MIT License
256 stars 212 forks source link

Added new test for grade school exercise #885

Closed ThGnommy closed 3 months ago

ThGnommy commented 3 months ago

Hello!

After finishing the exercise grade-school, I noticed that a test is missing when looking at the instructions. So, I added it.

From the instructions:

Note that all our students only have one name (It's a small town, what do you want?) and each student cannot be added more than once to a grade or the roster. In fact, when a test attempts to add the same student more than once, your implementation should indicate that this is incorrect.

Please tell me if I missed something or if there is room for improvement.

Thank you!

github-actions[bot] commented 3 months ago

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.