exercism / cpp

Exercism exercises in C++.
https://exercism.org/tracks/cpp
MIT License
259 stars 217 forks source link

tests: update say exercise #903

Closed Elahi-cs closed 1 month ago

Elahi-cs commented 2 months ago

This PR is the result of running this command: image

using the test creation helper tool linked in the wiki, with some modifications to the code necessary for the tool to work.

github-actions[bot] commented 2 months ago

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

github-actions[bot] commented 2 months ago

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Elahi-cs commented 2 months ago

@vaeng everything should be fixed now. A couple of questions:

vaeng commented 1 month ago

Hello @Elahi-cs,

Thanks for your patience. You did the right thing to ask in the forum and also a nudge to look at this would have been fine.

I think your change is good and welcome, I wanted to ask the other maintainers for feedback before going further, but I haven't had the time yet.

As a result of my late reply, this September or will become tagged for hacktoberfest.

I will not be able to check your code until Tuesday, but maybe @siebenschlaefer has some capacity this weekend.

Elahi-cs commented 1 month ago

@ahans @vaeng Thank you both for your guidance and you feedback! Everything should be resolved now.

Related question: is there a way to run the CI tests locally? I don't like making the pipeline run the tests every time, but I also don't know if there's a good way other than using act.

ahans commented 1 month ago

Related question: is there a way to run the CI tests locally? I don't like making the pipeline run the tests every time, but I also don't know if there's a good way other than using act.

To run exactly what happens in CI, you probably won't get around using something such as act. But what happens is not exactly black magic and you can check the files in .github to see what's going on. The actual code tests are all managed via CMake and run here. So if you have all the prerequisites installed, you can this locally:

cmake .
# run all tests
cmake --build .
# alternatively, run just a single test:
cmake --build . -- test_say