search

exercism / crystal

Exercism exercises in Crystal.
https://exercism.org/tracks/crystal
MIT License
75 stars 53 forks source link

[BookStore] Inconsistent price per book? #696

Open ls1955 opened 4 weeks ago

ls1955 commented 4 weeks ago

Exercise's instructions said book price is $8, though it seems like book price in specs are $800, is it intentional?

ryanplusplus commented 4 weeks ago

Confusingly, the prices are in cents, not dollars. The upstream problem specification indicates that floats should not be used and a language-appropriate fixed point format should be used instead. I'm not aware of any built-in support so using an integer representation of price as cents is the way we went.

ls1955 commented 4 weeks ago

Thanks for the explanation. Should we change the dollars in instruction to cents, or just leave it as it is?

meatball133 commented 4 weeks ago

We are not going to change the instructions, what can be done is an append.

ls1955 commented 4 weeks ago

Append as in mentioning the specs use cent instead of dollar at the end of instructions?

meatball133 commented 2 weeks ago

Using an append file, e.g: https://github.com/exercism/crystal/blob/main/exercises/practice/roman-numerals/.docs/instructions.append.md

ls1955 commented 2 weeks ago

Ah, didn't know such file exists. If we were to add an append file, mind if I open a PR for that?