search

exercism / csharp

Exercism exercises in C#.
https://exercism.org/tracks/csharp
MIT License
344 stars 346 forks source link

Suggestions for Remote Control Cleanup Exercise #1951

Open haemmer-dave opened 2 years ago

haemmer-dave commented 2 years ago

Hi,

a few suggestions for improvment. First, the theory part is very short and lacks details/examples about nested classes accessing containing classes and vice versa. It makes it look like the solution is to create a nested "Telemetry" class. However, looking at the tests, "Telemetry" is used as a property. Simply creating a nested Telemetry class will lead to compiler error CS0572. For C# beginners this is extremely confusing.

Second, the wording of task 2 and its hint are confusing as well. How an Interface, instead of a simple access modifier, is the solution is neither handled in the theory part nor understandable to me using C# docs.

ErikSchierboom commented 2 years ago

Hi! Would you be willing to submit/work on a PR to improve this exercise?

haemmer-dave commented 2 years ago

Yea, I can submit something to improve the theory and task 1.

However, I don't feel confident in improving task 2: I don't see the connection between the, imho, actual solution -- which is simply using an access modifier -- and the Interface hint. Maybe I'm missing something but I'm confused about task 2, hence do not really know what the original author intended and how exactly it can be improved.

ErikSchierboom commented 2 years ago

I also feel that task 2 is quite weird. Not sure how we originally envisioned that working.

JeanAr7 commented 4 months ago

Hi it's 2024, the confusion still exists.