exercism / csharp

Exercism exercises in C#.
https://exercism.org/tracks/csharp
MIT License
333 stars 339 forks source link

Squeaky Clean (Task 4) - Mistake in Asserting Greek characters #2239

Closed poudigne closed 3 months ago

poudigne commented 3 months ago

I came across a weird issue while trying to accomplish the Task #4. Doing a Regex on the word would remove every Greek letter correctly. But, it was also removing the letter Ο resulting in MyFinder (when the test assert that the result is MyOFinder). While investigating why this was happening, I realized that the letter O a different letter than the one your keyboard will type.

To better explain the problem, I reproduced it using regex101 image

The first line was a copy paste from the exercice. The second line, was me deleting the letter O and typing the letter on my keyboard.

I would like to create a Pull Request that modify the assert, to validate the answer is MyFinder.

github-actions[bot] commented 3 months ago

Hello. Thanks for opening an issue on Exercism 🙂

At Exercism we use our Community Forum, not GitHub issues, as the primary place for discussion. That allows maintainers and contributors from across Exercism's ecosystem to discuss your problems/ideas/suggestions without them having to subscribe to hundreds of repositories.

This issue will be automatically closed. Please use this link to copy your GitHub Issue into a new topic on the forum, where we look forward to chatting with you!

If you're interested in learning more about this auto-responder, please read this blog post.

ErikSchierboom commented 3 months ago

That would be wrong though, as the task is:

5. Omit Greek lower case letters

Hence, upper case Greek letters must not be cleaned.