search

exercism / csharp

Exercism exercises in C#.
https://exercism.org/tracks/csharp
MIT License
342 stars 345 forks source link

Update GameOfLifeTests.cs #2287

Closed errolpais closed 1 month ago

errolpais commented 1 month ago

The rule in the instructions "Any dead cell with exactly three live neighbors becomes a live cell." is not explicitly covered by the test "Dead_cells_with_three_live_neighbors_become_alive".

This PR updates the relevant test to match the rule from the instructions more explicitly by covering both the scenarios where there are exactly 3 live neighbors and when there are 4 live neighbors for a cell.

github-actions[bot] commented 1 month ago

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

github-actions[bot] commented 1 month ago

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

ErikSchierboom commented 1 month ago

The tests are synced from a shared source (https://github.com/exercism/problem-specifications). If you think we should expand the tests, please open a forum post on our forum to discuss the change: https://forum.exercism.org/c/exercism/4