exercism / dart

Exercism exercises in Dart.
https://exercism.org/tracks/dart
MIT License
57 stars 98 forks source link

Regenerate robot-simulator #460

Closed kytrinyx closed 1 year ago

kytrinyx commented 2 years ago

This regenerates the test suite for robot-simulator. In doing so it:

I'm not sure if moving the expected() definition violates dart style. In the generator I have custom initialization at the top, and this felt like it was basically the same thing, so I didn't introduce another way of customizing.

If you have strong feelings about it, I can change it.

Stargator commented 2 years ago

I'm not sure if moving the expected() definition violates dart style. In the generator I have custom initialization at the top, and this felt like it was basically the same thing, so I didn't introduce another way of customizing.

The Dart style guide does not get into that level of detail, in terms of the order of public, private, or customize logic.

My only concern is pushing the main() down to the bottom. it's a central part of a dart app so I'm find with some global properties/references being defined as long as it does not obscure the main().

I don't think this PR does that, so I have no issue.