Closed Stargator closed 4 months ago
I though that Exercism is trying to use hashes instead of versions. @ErikSchierboom am I misunderstanding
Yeah, we deliberately use hashes as versions risk introducing section risks, as someone can republish a version with a different, dangerous commit. It's worth noting this has actually previously happened, so it definitely feels like a real risk.
However, I do wonder if for "official" GitHub actions such as checkout
, we can rely on the versions.
@iHiD okay, I wasn't aware of Exercism's policy on this. Could the track's test.yml still use versions? Or should we just drop this PR?
EDIT: Also, shouldn't PRs have enough checks to verify before we update an action that it's working properly?
Also, shouldn't PRs have enough checks to verify before we update an action that it's working properly?
I think the issue is that actions can read secrets. And so if someone maliciously changes an action upstream and then we inadvertently run it, we leak things.
I'll leave @ErikSchierboom to answer your other questions as he knows more! :)
We have a section about this in the docs: https://exercism.org/docs/building/github/gha-best-practices#h-pin-actions-to-shas
You could consider changing the dependabot frequency.
Closing this due to Exercism policy
You could consider changing the dependabot frequency.
@ErikSchierboom I don't have permissions to change the Dependabot settings for this repo
You do though, as it is configured in https://github.com/exercism/dart/blob/main/.github/dependabot.yml (ping me in the PR)
This should reduce the number of Dependabot PRs that are created and reviewed