Closed fapdash closed 1 week ago
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.
If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
[no important files changed]
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin
in a comment. Thank you!
I looked through the changelog of the 3.3 and 3.4 releases and the potential for breakage of student solutions seems low, but not zero. See https://github.com/dart-lang/sdk/issues/54056
v3.2 is only a few months old. It seems premature to drop it. What's your motivation for this change?
@glennj I wanted this repo to match the test runner after https://github.com/exercism/dart-test-runner/pull/84. Should I only change the Dart version the GHA is running on?
OK, but why are you suggesting upversioning the test runner? What's the rationale behind it all?
Two reasons:
I'm fine with any changes you suggest to this PR, my goal was to make the track run on the latest stable Dart release before I start diving into the track as a student.
I'd suggest you work on the exercises first, and if things aren't working like you expect then we can look at upgrading.
@fapdash, please note the last update took us from 2.18 to 3.2. So we were behind on supporting the current major stable version of Dart.
Dart 3.4 can still be used by students because our current setup (sdk: '>=3.2.0 <4.0.0'
) supports it.
When Dart 4.0 comes out, we'll likely to wait until 4.1 or 4.2 before switching to let things settle down.
I'm not entirely against this change, but per @glennj's guidance, I think it the impacts on students should be weighed against the rewards.
There's nothing stopping students from using Dart 3.3 or 3.4, or a future 3.x. Unless there's an exercise that is not working or the test runner can't function without an upgrade, there doesn't seem to be a good reason to update.
Sure thing, closing then.
See https://github.com/exercism/dart-test-runner/pull/84 for associated test runner change.