search

exercism / elixir-analyzer

GNU Affero General Public License v3.0
31 stars 32 forks source link

Add high school sweetheart analyzer #186

Closed Lgdev07 closed 3 years ago

Lgdev07 commented 3 years ago

Closes #86

Since we need more discussion on multiline string, I only implemented the functions reuses analysis.

Related comment log PR: https://github.com/exercism/website-copy/pull/2097

Lgdev07 commented 3 years ago

Thank you very much for the review @jiegillet, I will adjust based on your comments :smile:

jiegillet commented 3 years ago

Nicely done. Make tests pass and that's a wrap :)

angelikatyborska commented 3 years ago

Make tests pass and that's a wrap :)

Not so fast! We still need a PR in https://github.com/exercism/website-copy with the actual comment 🙂

jiegillet commented 3 years ago

Oops, sorry I'm too excited :D

Lgdev07 commented 3 years ago

Make tests pass and that's a wrap :)

Not so fast! We still need a PR in https://github.com/exercism/website-copy with the actual comment slightly_smiling_face

Hi @angelikatyborska, I created the PR: https://github.com/exercism/website-copy/pull/2097 :)

angelikatyborska commented 3 years ago

👍

The CI reveals that the path to the file with the comment is not correct. I checked and it's correct in website-copy (with dashes), so it needs to be updated in this PR.