Add basic New Passport analysis

Br1ght0ne commented 3 years ago

Close #202. Depends on https://github.com/exercism/website-copy/pull/2106.

jiegillet commented 3 years ago

OK, I looked into it more, and it's not you, it's the CI.

CC @angelikatyborska Unfortunately it looks like the GHA is not after all checkout it the latest version of the elixir repo but rather the version currently committed (which does not have new-passport yet and that's why the test fails). I'm sorry I missed that. git submodule update is horribly named because it doesn't actually update the submodule without --remote.

Temporary fix, use git submodule update --remote on this branch, it should get the latest version, and commit that. It didn't work well for me until I modified .gitmodules to add the name of the branch (I pushed that change here to see if it would help, it did not).

Real fix: modify the GHA.

Br1ght0ne commented 3 years ago

@jiegillet Anything for me to act on here?

jiegillet commented 3 years ago

Well, yes, two things:

we need to figure out your mix format issue with this PR and all of the others. Which version of Elixir do you use?
use git submodule update --remote and commit the new version of elixir so the tests can pass. I will figure out a long term plan later.

Br1ght0ne commented 3 years ago

I was using 1.11.2. I'll do the update and see how it goes.

angelikatyborska commented 3 years ago

There were breaking changes to mix format's behavior in 1.12. Form the changelog:

[Code] Do not add newlines around interpolation on code formatting. Note this means formatted code that has interpolation after the line length on Elixir v1.12 won't be considered as formatted on earlier Elixir versions

jiegillet commented 3 years ago

The test issue was fixed in #211. Could you merge in/rebase to main?

exercism / elixir-analyzer

Add basic New Passport analysis #204