exercism / elixir-analyzer

GNU Affero General Public License v3.0
30 stars 32 forks source link

Closes #398 - Fixed newsletter analysis to allow guard clause #400

Closed octowombat closed 11 months ago

octowombat commented 11 months ago

Following discussions with @jiegillet and an upstream code fix.

jiegillet commented 11 months ago

Sorry one last thing: for completeness, we should add tests for all 8 cases, something like

  test_exercise_analysis "open_log accepts 8 several variants",
    comments_exclude: [ElixirAnalyzer.Constants.newsletter_open_log_uses_option_write()] do
   [ defmodule Newsletter do
        import File
        def open_log(path) when is_binary(path) do
          open!(path, [:write])
        end
    end
  end,
   ....
]
octowombat commented 11 months ago

My pleasure