exercism / elixir-analyzer

GNU Affero General Public License v3.0
30 stars 32 forks source link

Is Enum.reduce the "best fitting Enum function" for total_quantity in `boutique-inventory`? #433

Open mikegehard opened 1 month ago

mikegehard commented 1 month ago

Solution Implementation:

def total_quantity(item) do
   Map.values(item.quantity_by_size)
   |> Enum.sum()
end

The solution says:

image

I agree that reduce is a good function/concept to practice with for this solution but "best fitting" seems like a stretch. It took me a long time to understand the concept of reduce when learning functional programming and this may be a head scratcher for some folks new to Elixir and functional programming togther.

Would it be possible to change that message to say "Use the Enum.reduce function in the total_quantity function to practice."?

This doesn't give folks who can't figure out reduce right away the feeling like they are doing it "wrong".