exercism / elixir-representer

GNU Affero General Public License v3.0
10 stars 6 forks source link

Fix errors for all dancing-dots submissions #97

Closed angelikatyborska closed 6 months ago

angelikatyborska commented 6 months ago

Resolves https://github.com/exercism/elixir-representer/issues/96

In a separate PR, I would love to add some sort of smoke test that would run the formatter for every real exercise and check that it produced a representation. It would require to correctly include the exemplar solution + extra files ( just the exemplar doesn't cause a crash for dancing-dots), or maybe just run it on an empty solution? Not sure.

jiegillet commented 6 months ago

In a separate PR, I would love to add some sort of smoke test that would run the formatter for every real exercise and check that it produced a representation. It would require to correctly include the exemplar solution + extra files ( just the exemplar doesn't cause a crash for dancing-dots), or maybe just run it on an empty solution? Not sure.

We could do that in the CI fairly easily. I did something like this in the Elm Analyzer, it pulls the Elm repo and check all exercises.

angelikatyborska commented 6 months ago

@ErikSchierboom can I or you do something to re-run the representer on all dancing-dots solutions for Elixir?

angelikatyborska commented 6 months ago

Hmm, or maybe this happens automatically

ErikSchierboom commented 6 months ago

@angelikatyborska I was already enqueuing the submissions for reprocessing :) But yes, it can take a while

ErikSchierboom commented 6 months ago

It's working :) https://exercism.org/tracks/elixir/exercises/dancing-dots/solutions