Closed angelikatyborska closed 1 year ago
@angelikatyborska I was just peeking into this when I noticed you assigned this ha!
At first glance some minor changes to mix.exs and an upgrade to dialyxer.
I'm running into an issue with the TakeANumberDeluxe test (🤔 didn't we just fix an issue on that one?) where the GenServer is exiting on invalid configuration. Just going over that at the moment
Ah, sorry 😅 I opened a draft PR https://github.com/exercism/elixir/pull/1332 - draft because I don't know yet how to handle that failing TakeANumberDeluxe test. Let me know if you figure it out!
All good! I'll dig it out and then move over to your PR discussion
@dabaer If you're interested in helping out further, now that https://github.com/exercism/elixir/pull/1332 is merged, you could open PRs for the 3 other repositories
Will do 🎉
♥️💙💚💛💜
It's live and I wrote a little site update:
It was a wild ride with breaking changes, and certainly one of the largest PR threads I've ever seen.
Thank you and @neenjaw for your guidance on these commits, it's really expanded my knowledge of Elixir!
An example of how to do it can be seen in previous PRs for Elixir 1.14: