exercism / elixir

Exercism exercises in Elixir.
https://exercism.org/tracks/elixir
MIT License
625 stars 398 forks source link

Include all IO in the last test #1460

Closed CamilleMo closed 7 months ago

CamilleMo commented 7 months ago

This fix adds all the IO that are displayed when the CharacterSheet.run() function is called

github-actions[bot] commented 7 months ago

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

github-actions[bot] commented 7 months ago

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:


Automated comment created by PR Commenter 🤖.

angelikatyborska commented 7 months ago

This change goes against the intention of the test. The test is named:

"it inspects the character map"

There is already another test that tests that the questions are printed:

    test "it asks for name, class, and level" do
      io =
        capture_io("Susan The Fearless\nfighter\n6\n", fn ->
          RPG.CharacterSheet.run()
        end)

      assert io =~ """
             Welcome! Let's fill out your character sheet together.
             What is your character's name?
             What is your character's class?
             What is your character's level?
             """
    end