Closed jiegillet closed 5 months ago
Thank you for contributing to exercism/elixir
💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.
Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
General steps
x:size/{tiny,small,medium,large,massive}
)? (A medium reputation amount is awarded by default, see docs)Any exercise changed
<exercise>/.meta/config.json
(see docs)?<exercise>/.meta/design.md
) need to be updated to document new implementation decisions?Practice exercise changed
prerequisites
, practices
, and difficulty
in config.json
need to be updated?Practice exercise tests changed
<exercise>/.meta/tests.toml
need updating?Automated comment created by PR Commenter 🤖.
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.
If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
[no important files changed]
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin
in a comment. Thank you!
Closes #1491
We had some tests that are not in the canonical data, including some that seems to actually break the rules (maybe even all of them). This makes our example implementation a bit awkward, because we know it can break the rules, but I didn't change it.