exercism / elixir

Exercism exercises in Elixir.
https://exercism.org/tracks/elixir
MIT License
625 stars 398 forks source link

Update to Elixir 1.17 #1495

Closed jiegillet closed 4 months ago

jiegillet commented 5 months ago

This time I beat you to it @angelikatyborska :)

Quite a few code changes, a bunch of warnings for descending ranges (10..1 should now be 10..1//-1) and a few more specific ones that I will comment on.

What do you think about the mix files

  def project do
    [
      app: :ledger,
      version: "0.1.0",
      # elixir: "~> 1.10",
      start_permanent: Mix.env() == :prod,
      deps: deps()
    ]
  end

should we bother updating the comment to 1.12?

github-actions[bot] commented 5 months ago

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:


Automated comment created by PR Commenter 🤖.

jiegillet commented 4 months ago

Yay! Thanks for the review :) One link is dead but we can fix that some other time