Closed jiegillet closed 4 months ago
Thank you for contributing to exercism/elixir
💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.
Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
General steps
x:size/{tiny,small,medium,large,massive}
)? (A medium reputation amount is awarded by default, see docs)Any exercise changed
<exercise>/.meta/config.json
(see docs)?<exercise>/.meta/design.md
) need to be updated to document new implementation decisions?Practice exercise changed
prerequisites
, practices
, and difficulty
in config.json
need to be updated?Concept exercise changed
prerequisites
and practices
in config.json
need to be updated?Concept exercise tests changed
@tag task_id
?Automated comment created by PR Commenter 🤖.
Yay! Thanks for the review :) One link is dead but we can fix that some other time
This time I beat you to it @angelikatyborska :)
Quite a few code changes, a bunch of warnings for descending ranges (
10..1
should now be10..1//-1
) and a few more specific ones that I will comment on.What do you think about the mix files
should we bother updating the comment to 1.12?