Closed lorisp1 closed 4 months ago
Thank you for contributing to exercism/elixir
💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.
Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
General steps
x:size/{tiny,small,medium,large,massive}
)? (A medium reputation amount is awarded by default, see docs)Any exercise changed
<exercise>/.meta/config.json
(see docs)?<exercise>/.meta/design.md
) need to be updated to document new implementation decisions?Concept exercise changed
prerequisites
and practices
in config.json
need to be updated?Concept exercise tests changed
@tag task_id
?Automated comment created by PR Commenter 🤖.
Thanks!
Ah, right, we can't just merge this because tests must work in many Elixir versions... @jiegillet thoughts?
The :eof
value seems to have been inserted in 1.13, so 1.12 is failing.
Version 1.12 doesn't get security patches anymore, I can only assume that the timing for hard deprecation is linked to that. In that light, I think we could drop support for 1.12, if it's not officially safe, it makes sense for Exercism to discourage people using it.
@lorisp1 could you rebase this on main? (or merge main)
Thanks again!
Hi, test
close_log closes the file
contained in Newsletter exercise is reporting the following warning if run with Elixir 1.17.1:This PR changes
IO.read
function call as suggested by the warning.