Automatically push Docker image to Docker Hub

exercism / elm-test-runner

GNU Affero General Public License v3.0

3 stars 5 forks source link

Automatically push Docker image to Docker Hub #10

Closed ErikSchierboom closed 3 years ago

ErikSchierboom commented 4 years ago

The v3 development environment uses Docker images from Docker Hub for all the tooling. This allows for easy testing of the various tooling components (analyzers/representer/test-runners).

This PR adds a GitHub Actions workflow to automatically build and push a new Docker image whenever something is merged to master.

See https://github.com/exercism/v3/issues/2727

mpizenberg commented 3 years ago

@ErikSchierboom I've updated this action to V2 and wanted to try it on PR but it seems the DOCKERHUB_TOKEN secret is missing. Is this because we are on PR and not on push or is it truly missing? I can't tell since I've not access to the repo parameters.

ErikSchierboom commented 3 years ago

@iHiD Could you add the secret?

iHiD commented 3 years ago

It's DOCKERHUB_USERNAME and DOCKERHUB_PASSWORD. Both are present.

ErikSchierboom commented 3 years ago

Merged! I'm using your work on using the new Docker build-push action to update the C# test runner too: https://github.com/exercism/csharp-test-runner/pull/36 That PR also attempts to merge the two existing Docker publishing workflows into one workflow. Thanks for the work!