search

exercism / elm-test-runner

GNU Affero General Public License v3.0
3 stars 5 forks source link

Actually update tests to version 3 #35

Closed jiegillet closed 2 years ago

jiegillet commented 2 years ago

Currently we mark the results.json with a "version": 3, but it's not actually earned. According to the docs, version 3 means that the test runner can link individual tests to a task, which we don't do.

According to this discussion, it involves updating the version of elm-test-rs. It will also involve a large PR in exercism/elm to tag all the concept exercise tests to their task.

jiegillet commented 2 years ago

I forgot to mention that the UI for showing the task ID is live now.

Screen Shot 2022-03-26 at 21 09 33
mpizenberg commented 2 years ago

I forgot to mention that the UI for showing the task ID is live now

:tada:

mpizenberg commented 2 years ago

Really nice to have the UI for tasks :) My bad, must be my mistake if I updated the version to 3 while this was meant for tests categorized by tasks. Or the version 3 spec changed at some point to include those. The good thing about still having a relatively small learning track is that it won't be that big to update a few tests files. Usually, tests are already close together for the same task. So it will only be a matter of transforming tests descriptions like this:

-- before
describe "concept"
  [ test "test 1a" <| ...
  , test "test 1b" <| ...
  , test "test 2a" <| ...
  ]

-- after
describe "concept"
  [ describe "1" -- the task id
    [ test "test 1a" <| ...
    , test "test 1b" <| ...
    ]
  , describe "2"
    [ test "test 2a" <| ...
    ]
  ]
jiegillet commented 2 years ago

Closed via #36.