add circular-buffer, part of 48 in 24

exercism / emacs-lisp

Exercism exercises in Emacs Lisp.

https://exercism.org/tracks/emacs-lisp

MIT License

46 stars 43 forks source link

Closed kmarker1101 closed 3 months ago

kmarker1101 commented 3 months ago

@BNAndras I am not sure why this is failing CI. Any suggestions?

BNAndras commented 3 months ago

I'll take a look later this week and let you know if I see anything amiss.

kmarker1101 commented 3 months ago

Thanks. Think I have it. Had to (require 'eieio) in test file.

kmarker1101 commented 3 months ago

Hold up on this. I need to make sure some tests check for a specific error message on some operations, instead of just that it throws an error.

kmarker1101 commented 3 months ago

good to review now.

BNAndras commented 3 months ago

Looks good. If you rebase the PR to fix the merge conflict, I can merge the PR.

kmarker1101 commented 3 months ago

should be ready to merge now.