search

exercism / erlang-tests-generator

MIT License
1 stars 8 forks source link

collatz-conjecture: Return or throw `badarg` on invalid input #25

Closed wojtii closed 5 years ago

wojtii commented 5 years ago

Closes #21 Please let me know if I should also change example from https://github.com/exercism/erlang/blob/master/exercises/collatz-conjecture/src/example.erl to match test cases?

NobbZ commented 5 years ago

The example.erl as well as the testfile and other stuff has to get updated when a PR is done in the main repo to update the actual testcases.

I'd be happy if you would do that as well, as I like to review generator changes side by side with the generated code.

wojtii commented 5 years ago

I've made related changes in erlang repo but checks are failing in some not related test cases, could you take a look? https://github.com/exercism/erlang/runs/270160143

NobbZ commented 5 years ago

I'm not sure why that one failed. I re-ran and its green now. Will do the actual review during lunch time (in ~2h).